Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgmt, update containerregistry to 2023-07-01 #36688

Merged
merged 2 commits into from
Sep 12, 2023
Merged

mgmt, update containerregistry to 2023-07-01 #36688

merged 2 commits into from
Sep 12, 2023

Conversation

v-hongli1
Copy link
Contributor

@v-hongli1 v-hongli1 commented Sep 11, 2023 •
edited
Loading

relate to issue#4492

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 11, 2023 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-resourcemanager-containerregistry

@v-hongli1 v-hongli1 marked this pull request as ready for review September 11, 2023 05:56
@v-hongli1 v-hongli1 closed this Sep 12, 2023
@v-hongli1 v-hongli1 reopened this Sep 12, 2023
@XiaofeiCao
Copy link
Contributor

XiaofeiCao commented Sep 12, 2023 •
edited
Loading

You'll probably need revapi.skip for azure-resourcemanager-containerregistry.

@weidongxu-microsoft
Copy link
Member

You'll probably need revapi.skip for azure-resourcemanager-containerregistry.

Let's see the revapi result first.

@weidongxu-microsoft
Copy link
Member

You'll probably need revapi.skip for azure-resourcemanager-containerregistry.

Let's see the revapi result first.

OK, these are expected https://dev.azure.com/azure-sdk/public/_build/results?buildId=3075303&view=logs&jobId=b70e5e73-bbb6-5567-0939-8415943fadb9&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=68a849d6-f425-5f38-d450-7e2c3d1df885

@XiaofeiCao XiaofeiCao mentioned this pull request Sep 12, 2023
Merged
@v-hongli1 v-hongli1 merged commit 360301f into Azure:main Sep 12, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaofeiCao XiaofeiCao XiaofeiCao approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-hongli1 @azure-sdk @XiaofeiCao @weidongxu-microsoft